In a recent PR , an interesting point was raised about improving the labels in the family editor dialog. This post is to summarise the discussion in the PR and to allow the discussion to continue. Firstly, the image below highlights the labels being discussed [image] This is a good starting point …

@emyoulation commented in the PR: I like when the user can choose. The Family object editor looks a bit “unfinished” with the current “Father/partner1” and “Mother/partner2” labels. The use of “Spouse” would be a misnomer when the Family’s Type is “Unknown” or “Unmarried”

I commented in the PR: whilst adding options sounds appealing, every option comes with a long term maintenance cost (keeping it working, documenting etc.). This option would probably have to be per family as well. Can we devise a heuristic that does the right thing? Is the label signifying the re…

To be clear. You are proposing that once a Family is formed, with or without children, the labels for the heads of the family will change based upon the configuration of the family and the Type selected. Do you see any change in the labels before any person is added?

The only issue I see is that semantically (in a few places) the “Partner 1” position is used in the code to search for “fathers” (male parent), and “Partner 2” for “mothers” (female parent). It would take some work to remove that connection. For example, instead of searching for “Fathers” (partner-…

I was envisaging that the label would be dynamic. Every time the dialog is displayed, or the dialog content is edited, the labels would be refreshed. So when adding a new family, initially both genders are unknown, no children and unknown relationship type. So, if the table above is used, the label…

The only issue I see is that semantically (in a few places) the “Partner 1” position is used in the code to search for “fathers” (male parent), and “Partner 2” for “mothers” (female parent). It would take some work to remove that connection. I was only thinking of adjusting the family editor dial…

My 2 cents… leave it as it is. We know how it works or what the fields represent, the change just makes things more complicated with little benefit.

An alternative would be to just remove these labels. Are they really necessary?

That’s certainly simpler! The select and add buttons then become a mini-toolbar

Labels in Edit Family Dialog

Development

dsblank January 2, 2025, 1:18pm 10

Right, but it should probably be prevented to have “Partner 1” be Female, and “Partner 2” be Male, as that swaps the usage in the code. Oh, I see your chart doesn’t even include that option.

Topic		Replies	Views
Same Sex Couples Help	2	600	November 20, 2022
Relationship Descriptors Help	8	186	January 7, 2026
Additional Gender Options Ideas	121	4085	November 1, 2024
Display Name Editor - Patronymic/Matronymic separation Ideas	11	1931	October 18, 2020
How to create a homosexual/gay family Help	2	1142	November 14, 2020

Labels in Edit Family Dialog

Related topics