Should addons PR include version number update?

Development
1

Maintainers and contributors: what is the expected practice for updating version numbers when creating a PR an addon?

Most open PRs I looked at in the gramps/addons-source repository include the code change but do not bump up the version number in the addon’s gpr.py file. Based on this message from @prculley I inferred that the version number is updated during the release process. Is that correct?

This question came up in a comment I made on PR-543 by @GaryGriffin and @jpschewe

1 Like
2

Yes the “patch part” of the version number (= MAJOR.MINOR.PATCH) ist updated during the addon build process e.g. 1.1.3 => 1.1.4
You can find this step in addons-source/make.py.

2 Likes
3

Thanks, @Mattkmmr. In this case case I will ask for the version number changed to be backed out.

1 Like
4

This topic was automatically closed 30 days after the last reply. New replies are no longer allowed.