I have a patch for bug #13468 which is about 5 new lines.
When I run through Black, it modifies hundreds of lines.
At the moment I have a branch with one commit doing the reformat and one with the bug fix.
The last time I submitted a PR it was said that I should merge-squash first, but if I did that then the substantial changes would be swamped.
Are add-ons subject to the same quality requirements as the main Gramps source? If so, how do I approach it?
The addons-source repo hasn’t been formatted with Black and CI checks for Black formatting on GitHub are not enabled as they are for the gramps repo.
For now, if your goal is to keep your changes clearly visible in a diff, disable Black formatting in your local environment for the addons-source project.
My “goal” is to submit in whatever is the most acceptable way. I guess the simplest is to provide only the bug fix itself.
Edit: Now done.
This topic was automatically closed 30 days after the last reply. New replies are no longer allowed.