I just released version 0.1.49 of FTV, which adds an option to gray out people in the tree based on the filter (enabled by default) and fixes a problem where the tree reloads every time the Gramps window loses or gets focus.
An example when filtering for the name “Garner” in the example database:
That’s gorgeous! (Yammering on since Discourse insists that complimentary responses be at least 20 characters.) Looking forward to trying some PDF outputs of expander tweaked trees!
Having just installed v0.1.49 I get:
Traceback (most recent call last):
File "C:\Program Files\GrampsAIO64-5.2.4\gramps\gui\viewmanager.py", line 902, in __create_page
page = page_def(pdata, self.dbstate, self.uistate)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "C:\Users\Common\AppData\Roaming\gramps\gramps52\plugins\FamilyTreeView\family_tree_view.py", line 174, in __init__
config.connect("preferences.theme", lambda *args: GLib.idle_add(self.close_info_and_rebuild))
File "C:\Program Files\GrampsAIO64-5.2.4\gramps\gen\utils\configmanager.py", line 518, in connect
self._validate_section_and_setting(section, setting)
File "C:\Program Files\GrampsAIO64-5.2.4\gramps\gen\utils\configmanager.py", line 428, in _validate_section_and_setting
raise AttributeError(f"No such config setting name: '{section}.{setting}'")
AttributeError: No such config setting name: 'preferences.theme'
EDITED TO ADD:
deleting the FTV folder from the plugins folder and reinstalling (and restarting Gramps) makes no difference, the chart gives the above crash.
@stuck@Bouscram
Sorry! It seems that my workaround can’t handle the case where the themes addon is missing. I just pushed a hotfix. Please try v0.1.50.
I’ll try to find another workaround that updates the tree when the theme is changed and doesn’t break anything if the themes addon is not installed.
Sorry again!
@stuck@Bouscram
I figured out how to check if a certain configuration key is available. In the latest version (v0.1.51) the addon checks if the configurations of the themes addon exist and only connects to the config keys if they do. I tested with and without the themes addon (removing the config lines from the ini file after deleting the themes addon) and it seems to work in both cases.
Thank you @Nick-Hall! It will certainly take many weeks, probably a few months, before the addon reaches a state that I would say it is stable in the sense that no major features are being added (which always carries the risk of introducing new bugs) and it has been tested by multiple people for a while.
I’m sure the review of the pull request to merge this into gramps-project/addons-source will be quite intense and therefore take some time (currently over 7500 lines of python code, including comments, empty lines, etc., if that can give an indication).
Still impressed with this addon!
However I have one issue, If marriage happens between relatives, the ancestor tree is shown several times.
I would have expect that it was showed once, and the put a sign on the others, that this person is already shown.
Is this on purpose?
This is not exactly intentional, but I did not implement a check that a person has been processed before. The algorithm just re-processes the person and it’s descendants/ancestors (depending on where the person appears). This “problem” has been discussed briefly before (starting here) and I wrote that it would get messy if I tried to find a general approach to show the person only once and connect it to remote relatives (which is what the Graph View is really good at).
That’s a good idea. The discussion linked above discussed something similar (“graying out” and “some interface”). Your idea to use a symbol makes me think of new ideas. This should be possible, although the first implementation might just be a basic concept. I have a feeling that this problem and it’s solution will take a few iterations to reach a certain level of maturity. I’ll add it to my list and @mention you when there’s a first draft to discuss.
In order to develop and test this, it would be great if someone could point me to an example tree where many of these loops occur. I’ve seen the royal example tree in @emyoulation’s repo, which definitely shows pedigree collapse, but I’m not sure if there is the problem you describe with marrying descendants in that tree.
If anyone has a small example tree that has many of these loops, feel free to let me know.
Printing now works without resetting the view! Thanks!
Just tried printing to SVG with some less saturated colors in Color preferences, imported to Inkscape,
(in Inkscape: hand-deleted the expander gadgets, dropped the outline borders from 2px to .5px., output to .webp format. Inkscape was too hard to scale the image. So did that in Gimp.)
No matter how the abbreviating Configuration options were set, I couldn’t force it to NOT abbreviate. (2 hours later, the name formatting options finally applied reliably. Is there something cached?)
By the way, which size Thumbnails do you use for the screen and/or printing? Are these the “Normal” or “Large” (See the PR 245 for how the gvfamilylines.py was upgraded to use Large thumbnails.)
You probably already know that it also happens with descendants. For example, if a person remarries after their spouse dies, and the children from the first family are also in the second family, then you will see all of the descendants duplicated in the view.
I tried to find such a case in the “example” Gramps database by using the filter rule “People with multiple parent records” but did not find any.