Parent dialog within Gramps dialogs?

romjerome · April 18, 2025, 12:23pm

Hello.
I am wondering why ErrorDialog() does not set a parent value as default?

gramps/gui/dialog.py

master


      
                      if task2:
                          task2()
                  self.top.destroy()
                  if parent and parent_modal:
                      parent.set_modal(True)
          
              def get_response(self):
                  return self.response
          
          
          class ErrorDialog(Gtk.MessageDialog):
              def __init__(self, msg1, msg2="", parent=None):
                  Gtk.MessageDialog.__init__(
                      self, transient_for=parent, modal=True, message_type=Gtk.MessageType.ERROR
                  )
                  self.add_button(_("_Close"), Gtk.ResponseType.CLOSE)
                  self.set_markup('<span weight="bold" size="larger">%s</span>' % str(msg1))
                  self.format_secondary_text(msg2)
                  self.set_icon(ICON)
                  self.set_title("%s - Gramps" % str(msg1))
                  if parent:

It makes a while since I (can) understand that Dialogs provided by gramps interface are ignoring the parent dialog within gramps UI!

Sure, it will pop-up once there is an error. Anyway, all these dialogs are designed for Gramps UI. Maybe we could get ride of additionnal issue related to Gramps dialogs by setting something on init section?
e.g., parent=self.uistate.window

The default parent=None leads to the Gtk parent mapping issue. Sure, need to fix this on addon or whatever plugins. Maybe it is not the most intuitive way for re-using Gramps’ dialogs as we do not always know that parent=None. It is discouraged by Gtk, but within Gramps (e.g., via a tool, gramplet, or plugin), the main parent window should be “gramps”. Just a possible improvement by setting the main window as parent by default seems to be a logical way. I do not know why the default is None, but getting this Gtk warning by just re-using Gramps’ dialogs could be a little bit confusing during testing for an addon. Maybe to get ride of this issue, could provide a less confusing ecosystem for addons too?

emyoulation · April 18, 2025, 12:35pm

Is this related to the pervasive “mapped without a transient parent” warnings?

See Gtk-Message: GtkDialog mapped without a transient parent - #3 by prculley

0008128: GtkDialog mapped without a transient parent

romjerome · April 18, 2025, 1:29pm

Yes…
During testing, I got such warnings.
I was able to fix them by setting parent=self.uistate.window. I (too often) called ErrorDialog, but I missed some of them. So, once it occurs I fix it on my local version of the addon. But by looking at gramps/gui/dialog.py, we can see that most dialogs do not set parent dialog. Within gramps program it sounds a little bit strange as we are running the main dialog/window. I was able to get ride of the warnings, just wondering why there is no default set, this might (or not) limit such extra warnings.

Note, we know that such warning is not a blocking issue, but as I do not think that gramps-web, betty or others projects looking at gramps API, are also re-using these (Gtk) dialogs, why the default parent is None?

Topic		Replies	Views
Gtk-Message: GtkDialog mapped without a transient parent Development	4	1331	November 17, 2023
Command line argument parsing Development	2	447	March 13, 2022
Is it serious doc? Help prerequisite-mgmt	3	339	January 30, 2021
Context menus broken for Command Line Module Help	4	305	July 30, 2022
Keep getting errors about orientation when creating a new gramplet Development third-party-addon	13	224	April 8, 2024

Parent dialog within Gramps dialogs?

Related topics