@codefarmer asked a good question after a patch created by @kku was posted to MantisBT as General type Addon. (Thanks Kari!)
He asked whether it would have been better to post as a PR rather than as an patching Addon?
And, at first glance, that seems the ‘right’ way because it will be a permanent fix. But there are several drawbacks:
- there is a long leadtime for bug fix releases for the core application and longer yet for enhancements.
- only a small portion of the community can build a Gramps installation from source. So a narrow cross-section of users
- the patch will only be applied to active branches. (So users stranded on old versions will not have access to PR-based fixes.)
So perhaps a new testing protocol is warranted? If a change can be posted as a “beta” status Addon, the first step could be to release as an Addon for the current general release. After it passes some field testing, it can be submitted as a PR. And also as a “stable” status addon for as many versions of Gramps as viable, but that the PR will cannot reach.
This would have an added benefit. It will give developers experience creating a GENERAL type addon.
Reference:
- 0013146: Manage Family Trees dialog does not re-focus on selected tree after Sort (key column or direction) change