New FamilyTreeView Addon (Thread 2)

[stuck]

@ztlxltl I’ve either found another bug or it’s a ‘by design’ situation. It’s difficult to describe…

In my tree one of my third great grandfathers is the top of that line. He has two sons. The eldest son married and had one son. That line ends there. This child appears in FTV when his GF / my third great GF is set to home and active.

However, he disappears, and the marriage box of his parents displays no expander for him, if I change the active person to anyone in the generation below any of his cousins.

I expected the tree to redraw / become much wider and display him and his parents off to the left when the next gen down from his cousins are expanded but that doesn’t happen. Instead he disappears and the next gen down expand across where he was.

Can you visualise what I’m describing?

[ztlxltl]

@stuck
If I understand correctly what you are describing, the behavior is intentional. Most likely, the third great-grandfather you are looking at is in the patriline of the respective active person if you are missing the son of the eldest son. In general, for most ancestors of the grandparent generation and above, cousins cannot be placed without crossing lines. In general, only people on the very left (patrilineage) or very right (matrilineage) have enough space to the side to allow cousins to be shown. In fairness, they are not.
There are ideas on my todo list to show that there are hidden people that cannot be expanded. There are also ideas to expand people that cannot be expanded in the current implementation by simultaneously collapsing other people to make room for the expanded people.

[stuck]

OK, thanks, I thought it might be intentional.

[ztlxltl]

Since the last status update one month ago, the following enhancements have been implemented (as of v0.1.138):

• PR #27 by @roptat has been merged adding menu items to the context menu which can be used to add relatives to persons and families.

• Implementation of the “Add relative” feature which displays an overlay to add people/families related to the clicked person. This was highly requested by @csam here).

  When you click this button , the following overlay appears:
  

  

  There are three other variants of this overlay of varying complexity. You can choose one that best suits your workflow for adding new information to your tree in the config window on the Interaction page.

  • Variant with direct relationships only:
    

    

  • Variant with main relationships only (no alternative parents, no alternative families/spouses):
    

    
    
    At first glance, the screenshot above may not seem to have a lot of actions available, but if there are no parents/spouse yet, their empty boxes will allow you to add them.

  • Variant with all implemented options:
    

    

  The new overlay also supports dark themes:
  

  

  Please be careful with this new feature. Be sure to back up your tree before using it. But testing it and reporting bugs is highly appreciated. I think if there are any critical bugs, they will be reported and fixed soon.
  Note that FTV basically just opens the editing windows and connects the new person/family to existing people/families. It doesn’t create its own database transactions.

• Improvements for large trees: Since the progress meter allows you to cancel while the tree is being built, larger trees can be built without forcing the user to wait a potentially very long time and without Gramps freezing. Therefore, the following improvements have been made to FTV to display larger trees:

  • Show up to 100 ancestor and 100 descendant generations of the active person in one tree.
  • Increased zoom limit to allow for further zooming out.
  • Hide small canvas items (text, expanders, badges) when zooming out very far to improve performance.
  • Fix visual detail in minimap for large trees.

• The pull requests #28 and #36 by @TJB have been merged fixing multiple issues with the panel timeline.

• The event description is now shown by default for more event types by default (e.g. vocational, academic and other event types).

• FTV now uses only one page/tab in the config window and a page selection on the left side. This avoids confusion (e.g. see here) and allows for a tree-like organization of config pages in future updates.

• Several minor bug fixes and improvements.

As always, I’m looking forward to your valuable feedback!

[Bouscram]

Hello - I updated FTV this morning, and clicking on any person provokes an exception:

197472: ERROR: grampsapp.py: line 188: Unhandled exception
Traceback (most recent call last):
  File "/Users/cram/Library/Application Support/gramps/gramps60/plugins/FamilyTreeView/family_tree_view_widget_manager.py", line 893, in cb_call_function_once
    function(*data)
    ~~~~~~~~^^^^^^^
TypeError: FamilyTreeViewPanelManager.open_person_panel() missing 2 required positional arguments: 'x_person' and 'generation'

(Using Gramps 6.0.1)

[Bouscram]

Additionally, using the right-click menu to open the panel works fine

[ztlxltl]

@Bouscram

clicking on any person provokes an exception

I was able to reproduce this by setting the single click action to open the panel. I assume that’s the configuration you’re using.
I’ve fixed it in the latest version (v0.1.140). Can you check if the bug is fixed for you? If not, please specify which click/mouse configurations you are using.

Sorry for these kind of bugs. That’s the curse of having so many options. There is always a combination I am missing to test.

[stuck]

@ztlxltl I too have updated FTV, to v0.1.140 but I don’t get the crash reported by @Bouscram. I can select anyone in my tree without problem. I’m using Gramps 6.0.1 on Windows.

[ztlxltl]

v0.1.140 should fix the bug I was able to reproduce.

I think this bug only occurs with specific mouse click actions configured.

[Bouscram]

@ztlxltl

I’ve fixed it in the latest version (v0.1.140). Can you check if the bug is fixed for you? If not, please specify which click/mouse configurations you are using.

It’s corrected, thanks!
(by the way, I really like the “add relative” options )

[Brinycoolie]

I have finally had some time to try out the latest version and it is wonderful. Thank you so much for all the effort you have put into this.
I did find a slight curiosity, though.
It will only display about 3% of my entire tree at one time i.e. 364 of 10500 (according to the FTV filter display at the bottom right of the app) and this with the sidebar filter set to none and the generation up set to 19 and down also set to 19 (which should be sufficient to show everyone).

So my question is " what is the FTV filter number at the bottom right showing exactly? is it the number of visible nodes currently being shown as tweaked by the expanders only or is it that ‘and-ed’ with the sidebar filter of the whole tree?
Just curious.
brian

[ztlxltl]

@Brinycoolie

hank you so much for all the effort you have put into this.

@Brinycoolie
I hope you’ll forgive me if, out of laziness, I include a reference im my answer. I know this thread (and the previous one) is too big to find something easily, so it’s perfectly understandable if you weren’t able to find the little piece of information you were looking for.

@ztlxltl

• Information about the number of visualized people is displayed in the lower right corner in the format <people in tree>/<people in db>. If a filter is applied, it also shows how many of the filter results are visible in the tree.
  
  (The tree shows 44 people, there are 29068 people in the database, the filter matches 23 people in the database and all 23 are visible in the tree.)

If no filter is applied, the part in parentheses is omitted.

So yes, expanding/collapsing expanders will change the number. Most likely you have many “nth cousins (m times removed)” or other people in your database that cannot be visualized.

A little extra info: The numbers to the left of the slash count the number of person boxes, so if a person is visualized multiple times, it will be counted multiple times. Fixing this is on my todo list.

[csam]

One of the most common pictures is the wedding picture, and I always add such wedding picture (when available) to the family definition.
So when displaying the wedding info box, please also show the wedding picture, if there’s one.
Tia
Claus

[DaveSch]

You can add it in the configure settings’ Boxes section.

And while I am here.

While making changes in the configure settings, each little change updates the view instead of updating the view just once when the configure settings is closed. I had to put the family image back in and it was initially added to the bottom of the list. Move it up… rebuild view, move it up again, rebuild view, etc.

[emyoulation]

The “instant update” for Settings/Configuration is a common trait in Gramps.

@cdhorn had to add a refresh delay in the CardView settings.

The gadgets (like the number increment/decrement arrow gadgets) were too unresponsive when Gramps was refreshing too quickly. With the delay, the interface became more responsive.

See the CardView GitHub issue that talks about Gtk Timers:

Responsiveness of the live configuration changes

[csam]

Thanks @DaveSch, I wasn’t aware of this possibility.
However, it’s in the info box that opens, when you click the family box, I would like to have the image shown.

Another thing a bit more serious @ztlxltl . In the settings of Family Boxes, if I add an image line, and then try to change the size of image Gramps crashes - no error message.
This is Gramps v6.0.1, FTV 0.1.145 on MacOS Ventura

[DaveSch]

@csam

However, it’s in the info box that opens, when you click the family box, I would like to have the image shown

With the settings I provided, this is what displays.

[ztlxltl]

@csam

So when displaying the wedding info box, please also show the wedding picture, if there’s one.

@csam
Thanks for the suggestion. This shouldn’t be too hard, I’ll implement this in the near future.

---

@DaveSch

each little change updates the view instead of updating the view just once when the configure settings is closed

@DaveSch
This is on my todo list as it also annoys me a bit. This is not a strict requirement of the config window, so I should be able to add a save button and only then apply the changed configurations.

---

@csam

In the settings of Family Boxes, if I add an image line, and then try to change the size of image Gramps crashes - no error message.

@csam
Thanks for letting me know. I can’t reproduce it on Ubuntu. I will have to check on Windows later. Unfortunately, I don’t have a macOS machine to test on that OS.

[emyoulation]

@ztlxltl

@DaveSch

each little change updates the view instead of updating the view just once when the configure settings is closed

@DaveSch
This is on my todo list as it also annoys me a bit. This is not a strict requirement of the config window, so I should be able to add a save button and only then apply the changed configurations.

@cdhorn added a “5 second redraw deferral that resets each time an option is changed” to his CardView configuration editor. This gives the best of both worlds.

[ztlxltl]

@emyoulation

@cdhorn added a “5 second redraw deferral that resets each time an option is changed” to his CardView configuration editor. This gives the best of both worlds.

@emyoulation
I’m not sure this works well with large trees that take long to build. Also, because there are so many options for boxes, it can take more than 5 seconds to find what you want to change next. Increasing the delay might be inconvenient if you are only making small changes. I think I’ll try the save/apply button first, and if that causes confusion, I’ll try the more complex delay approach.