Updating a multipack Addon

Development Beta Testing
1

This is on Gramps 5.2.2 but it would probably be the same for Gramps 6

I just tried the update (0.1.67 to 0.1.70) button for 1 of the FTV addons in the Addon Manager
(Project URL: https://raw.githubusercontent.com/ztlxltl/FamilyTreeView/dist/gramps52)

All 5 seem to be linked somehow and a single update-click updated all 5 and then threw the following error 3 times:

88314124: ERROR: grampsapp.py: line 188: Unhandled exception
Traceback (most recent call last):
  File "/home/districtsupport/.local/lib/python3.11/site-packages/gramps/gui/widgets/styledtexteditor.py", line 698, in __set_fallback_icons
    icon = tool_button.get_child().get_child()
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'NoneType' object has no attribute 'get_child'

image
image1185×1049 119 KB

image
image1177×851 103 KB

2

@ztlxltl that’s an exception what I’ve received.

GRAMPS: 5.2.3 
Python: 3.10.12 
BSDDB: 6.2.9 (5, 3, 28) 
sqlite: 3.37.2 (2.6.0)
LANG: en_US.UTF-8
OS: Linux
Distribution: 6.8.0-52-generic
3

I have had this problem since very early versions of FTV.

4

Meanwhile on Windows (AIO 5.2.4) I’ve never had any errors when updating FTV. I just click on the update button for FTV, not on any of the associated addons, and everything updates at the same time.

5

The repository folder for the FTV addons-en.json is browsable but in a different branch (dist) from the source code (main). So to diagnose odd behavior in the Addon Manager which might be related to the list, we need to look at the /dist/gramps52/listings/

6

Although everyone describes this problem in the context of my addon, I believe this is a bug in the Addon Manager and is only noticed for my addon due to the frequent updates. I think the reason is that there are multiple plugins registered in a single directory. (I’m not sure if this problem would disappear if they were all registered in a single .gpr.py file, but I don’t think so.)

I strongly believe that registering multiple plugins in one addon directory is not much of a problem. In the Gramps addons-source repo, there are multiple directories with multiple .gpr.py files (e.g. FilterRules, FilterRules2, D3Charts, DNA).

I haven’t checked the bug tracker to see if this bug of the addon manager is already discussed there, but @emyoulation said that there are several known issues with the addon manager.

7

@Nick-Hall
Do the FTV addons need to be separated into separate folders (and separate .tgz files) for the Update button in Addon Manager to work without conflicts? Or does the Addon Manager need to be improved for Suites of Addons. (Like the 2 Rules expansion Packs)?

8

Putting multiple addons into a single folder shouldn’t cause a problem. We have been doing this for many years now. It may even have a benefit if consistent versions are required.

The side effect is that all addons in the folder will be installed or updated at once.

I’ll look into the styled text editor error. It appears that it is being run without its toolbar buttons.

1 Like