Should there be many "Events" filters under the General category out-of-the-box?

[codefarmer]

Gramps 6.0.4

While triaging bug 13947, I was unable to find the event filter rule that was required to replicate the bug. @daleathan mentioned it was a built-in and shared a snapshot and pointed me to code, but I am unable to find it in my local installation of Gramps 6.0.4, and even on a clean install of Gramps 6.0.4, and 6.0.3 in Windows Sandbox.

What am I missing? Why would the rules not show in my installation?

[SNoiraud]

This is not a gramps filter. I think the bug reporter add this file.

[daleathan]

For me my testing VM for Gramps has no Addons or modifications installed! So yes it is a builtin filter that I literally linked to the file in the Gramps bugreport and the issue has been confirmed also by @lordemannd and @Gioto has narrowed it down to the work @dsblank & @steveyoungs did in PR 1794 Refactor, fix, and optimizer filters/rules.

@codefarmer Are you able to go to Events category then select menu “Edit > Event filter Editor…“ then select “+ (Add a new filter)” and select “+ (Add another rule to the filter”) then use the search box on “Add filter” to find “Events of persons” it should filter the list and you can expand out “General” if you don’t see it then could it be language related to for both of you my VM is using US English only, can you share what language your Sandbox is running?

[daleathan]

Confirming file also exist in the Windows Gramps AIO installation see screenshot.

Translated names of the filter shown on Weblate see https://hosted.weblate.org/translate/gramps-project/gramps/en/?checksum=47e5abf591b4cf10&q=Events+of+persons+matching+the&sort_by=-priority%2Cposition#translations

[SNoiraud]

In the bug report, we have:File “C:\Program Files\GrampsAIO64-6.0.4\gramps\gen\filters\rules\event_matchespersonfilter.py”

That’s why I said this file doesn’t exist (event_matchespersonfilter.py)

I suppose we have an internal mecanism to replace event_xxx by event/xxx

[codefarmer]

@SNoiraud Very keen observation. So there’s a red herring here. The call stack in the defect appears to show the non-existent file:

C:\Program Files\GrampsAIO64-6.0.4\gramps\gen\filters\rules\event_matchespersonfilter.py

However, this is a consequence of the formatting changes in MantisBT (cc @Nick-Hall @lordemannd) which are mangling the actual filename (I ran into this before, but forgot!). If I edit the defect, I can see that the actual filename in the original data of the bug report is the correct file,

File "C:\Program Files\GrampsAIO64-6.0.4\gramps\gen\filters\rules\event\_matchespersonfilter.py", line 96, in apply_to_one
    db.get_person_from_handle(family.father_handle)

So now that we have that out of the way, @daleathan I have confirmed that in my working installation of Gramps 6.0.4 and 6.0.3 on two different PCs do not contain the person event filter mentioned (note, the file is present in the file system). I used the search box as you suggested and Gramps presented no results.

The PC and the Windows sandbox clean installations I mentioned are all US English, and again neither Gramps 6.0.4 nor 6.0.3 have that filter. Could you confirm this in a sandbox/clean environment? Do you have any addon rules installed?

[codefarmer]

Learn something new every day. The way to get the Events of persons matching the <person filter> to display itself is to switch to Events view when launching the filter dialog.

Thank you @lordemannd for making that clear in your latest comment in the defect.

[daleathan]

@codefarmer

I can see that the actual filename in the original data of the bug report is the correct file,

Makes sense that it is a mantisbt formatting issue as when I’m testing I had the actual error message in my text editor that I was referring to each time to confirm and did not notice the bug report displayed it incorrectly, @Nick-Hall @gramps-project another big reason to revert the mantisbt change please! Especially when even @SNoiraud a seasoned developer was misled over this!